-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Check if the maxWorkers has a value and raises an exception otherwise #4591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /** | ||
| * Copyright (c) 2014-present, Facebook, Inc. All rights reserved. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| * | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| import type {Argv} from 'types/Argv'; | ||
| import {check} from '../../cli/args'; | ||
|
|
||
| describe('check', () => { | ||
| it('returns true if the arguments are valid', () => { | ||
| const argv: Argv = {}; | ||
| expect(check(argv)).toBe(true); | ||
| }); | ||
|
|
||
| it('raises an exception if runInBand and maxWorkers are both specified', () => { | ||
| const argv: Argv = {maxWorkers: 2, runInBand: true}; | ||
| expect(() => check(argv)).toThrow(); | ||
| }); | ||
|
|
||
| it('raises an exception if onlyChanged and watchAll are both specified', () => { | ||
| const argv: Argv = {onlyChanged: true, watchAll: true}; | ||
| expect(() => check(argv)).toThrow(); | ||
| }); | ||
|
|
||
| it('raises an exception if findRelatedTests is specified with no file paths', () => { | ||
| const argv: Argv = {findRelatedTests: true}; | ||
| expect(() => check(argv)).toThrow(); | ||
| }); | ||
|
|
||
| it('raises an exception if maxWorkers is specified with no number', () => { | ||
| const argv: Argv = {maxWorkers: undefined}; | ||
| expect(() => check(argv)).toThrow(); | ||
| }); | ||
|
|
||
| it('raises an exception if config is not a valid JSON string', () => { | ||
| const argv: Argv = {config: 'x:1'}; | ||
| expect(() => check(argv)).toThrow(); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,6 +36,14 @@ export const check = (argv: Argv) => { | |
| ); | ||
| } | ||
|
|
||
| if (argv.hasOwnProperty('maxWorkers') && argv.maxWorkers === undefined) { | ||
| throw new Error( | ||
| 'The --maxWorkers option requires a number to be specified.\n' + | ||
| 'Example usage: jest --maxWorkers 2\n' + | ||
| 'Or did you mean --watch ?', | ||
|
||
| ); | ||
| } | ||
|
|
||
| if ( | ||
| argv.config && | ||
| !isJSONString(argv.config) && | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests, nice! I think we should at least check the core message of the error though.
Something like this would be more descriptive: