Skip to content

implement spyOnProperty method #5107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 18 commits into from
Jan 8, 2018
Merged

implement spyOnProperty method #5107

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
1a3b82a
feat: implement spyOnProperty method, fixes #5106
phra Dec 18, 2017
4cfb737
style: fix indentation of mock, runtime, jasmine2
phra Dec 18, 2017
65d884d
test: fix failing tests for spyOnProperty
phra Dec 18, 2017
a4a6313
test: implement tests for #1214
phra Dec 25, 2017
d26337c
style: fix eslint errors
phra Dec 25, 2017
7c4844d
refactor: proxy spyOnProperty call behind spyOn
phra Jan 4, 2018
afb0e96
refactor: remove useless console.log
phra Jan 4, 2018
05a303d
style: fix eslint errors
phra Jan 4, 2018
fc0de22
types: remove declaration of spyOnProperty
phra Jan 4, 2018
0a5e083
docs: add documentation for accessType argument of spyOn
phra Jan 5, 2018
c0894d9
docs: fix typo in spyOn docs
phra Jan 6, 2018
be83146
test(spyOn): fix typo in should throw on invalid input
phra Jan 6, 2018
e5aa9a6
test(spyOn): add tests for setters
phra Jan 6, 2018
26b5ddb
docs(spyOn): add example for spying on setters
phra Jan 6, 2018
95f0ab9
style: fix eslint errors
phra Jan 6, 2018
bd44ca5
refactor: format error messages with getErrorMsg()
phra Jan 8, 2018
37093f6
style: fix eslint errors
phra Jan 8, 2018
224eb25
revert: restore snapshotState.getUncheckedKeys()
phra Jan 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style: fix eslint errors
  • Loading branch information
@phra
phra committed Jan 4, 2018
commit 05a303d8896f8e25ed406ab0dc642f7046838ed0
2 changes: 1 addition & 1 deletion packages/jest-jasmine2/src/jasmine/spy_registry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export default function SpyRegistry(options: Object) {

this.spyOn = function(obj, methodName, accessType?: string) {
if (accessType) {
return this._spyOnProperty(obj, methodName, accessType)
return this._spyOnProperty(obj, methodName, accessType);
}

if (obj === void 0) {
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-mock/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@ class ModuleMockerClass {

spyOn(object: any, methodName: any, accessType?: string): any {
if (accessType) {
return this._spyOnProperty(object, methodName, accessType)
return this._spyOnProperty(object, methodName, accessType);
}

if (typeof object !== 'object' && typeof object !== 'function') {
Expand Down