Skip to content

implement spyOnProperty method #5107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 18 commits into from
Jan 8, 2018
Merged

implement spyOnProperty method #5107

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
1a3b82a
feat: implement spyOnProperty method, fixes #5106
phra Dec 18, 2017
4cfb737
style: fix indentation of mock, runtime, jasmine2
phra Dec 18, 2017
65d884d
test: fix failing tests for spyOnProperty
phra Dec 18, 2017
a4a6313
test: implement tests for #1214
phra Dec 25, 2017
d26337c
style: fix eslint errors
phra Dec 25, 2017
7c4844d
refactor: proxy spyOnProperty call behind spyOn
phra Jan 4, 2018
afb0e96
refactor: remove useless console.log
phra Jan 4, 2018
05a303d
style: fix eslint errors
phra Jan 4, 2018
fc0de22
types: remove declaration of spyOnProperty
phra Jan 4, 2018
0a5e083
docs: add documentation for accessType argument of spyOn
phra Jan 5, 2018
c0894d9
docs: fix typo in spyOn docs
phra Jan 6, 2018
be83146
test(spyOn): fix typo in should throw on invalid input
phra Jan 6, 2018
e5aa9a6
test(spyOn): add tests for setters
phra Jan 6, 2018
26b5ddb
docs(spyOn): add example for spying on setters
phra Jan 6, 2018
95f0ab9
style: fix eslint errors
phra Jan 6, 2018
bd44ca5
refactor: format error messages with getErrorMsg()
phra Jan 8, 2018
37093f6
style: fix eslint errors
phra Jan 8, 2018
224eb25
revert: restore snapshotState.getUncheckedKeys()
phra Jan 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style: fix eslint errors
  • Loading branch information
@phra
phra committed Jan 6, 2018
commit 95f0ab9a6f6faa989e1590ba9695af854d30d7c7
54 changes: 27 additions & 27 deletions packages/jest-mock/src/__tests__/jest_mock.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ describe('moduleMocker', () => {

describe('getMetadata', () => {
it('returns the function `name` property', () => {
function x() { }
function x() {}
const metadata = moduleMocker.getMetadata(x);
expect(x.name).toBe('x');
expect(metadata.name).toBe('x');
Expand Down Expand Up @@ -60,7 +60,7 @@ describe('moduleMocker', () => {

describe('generateFromMetadata', () => {
it('forwards the function name property', () => {
function foo() { }
function foo() {}
const mock = moduleMocker.generateFromMetadata(
moduleMocker.getMetadata(foo),
);
Expand All @@ -69,8 +69,8 @@ describe('moduleMocker', () => {

it('escapes illegal characters in function name property', () => {
function getMockFnWithOriginalName(name) {
const fn = () => { };
Object.defineProperty(fn, 'name', { value: name });
const fn = () => {};
Object.defineProperty(fn, 'name', {value: name});

return moduleMocker.generateFromMetadata(moduleMocker.getMetadata(fn));
}
Expand All @@ -93,7 +93,7 @@ describe('moduleMocker', () => {
});

it('special cases the mockConstructor name', () => {
function mockConstructor() { }
function mockConstructor() {}
const mock = moduleMocker.generateFromMetadata(
moduleMocker.getMetadata(mockConstructor),
);
Expand All @@ -102,8 +102,8 @@ describe('moduleMocker', () => {
});

it('wont interfere with previous mocks on a shared prototype', () => {
const ClassFoo = function () { };
ClassFoo.prototype.x = () => { };
const ClassFoo = function() {};
ClassFoo.prototype.x = () => {};
const ClassFooMock = moduleMocker.generateFromMetadata(
moduleMocker.getMetadata(ClassFoo),
);
Expand Down Expand Up @@ -131,7 +131,7 @@ describe('moduleMocker', () => {
},
},
nonEnumMethod: {
value: () => { },
value: () => {},
},
},
);
Expand Down Expand Up @@ -166,7 +166,7 @@ describe('moduleMocker', () => {

it('mocks ES2015 non-enumerable methods', () => {
class ClassFoo {
foo() { }
foo() {}
toString() {
return 'Foo';
}
Expand All @@ -190,7 +190,7 @@ describe('moduleMocker', () => {
});

it('mocks methods that are bound multiple times', () => {
const func = function func() { };
const func = function func() {};
const multipleBoundFunc = func.bind(null).bind(null);

const multipleBoundFuncMock = moduleMocker.generateFromMetadata(
Expand All @@ -202,7 +202,7 @@ describe('moduleMocker', () => {

it('mocks methods that are bound after mocking', () => {
const fooMock = moduleMocker.generateFromMetadata(
moduleMocker.getMetadata(() => { }),
moduleMocker.getMetadata(() => {}),
);

const barMock = moduleMocker.generateFromMetadata(
Expand Down Expand Up @@ -475,13 +475,13 @@ describe('moduleMocker', () => {
it('should mock constructor', () => {
const mock1 = jest.fn();
const mock2 = jest.fn();
const Module = jest.fn(() => ({ someFn: mock1 }));
const testFn = function () {
const Module = jest.fn(() => ({someFn: mock1}));
const testFn = function() {
const m = new Module();
m.someFn();
};

Module.mockImplementationOnce(() => ({ someFn: mock2 }));
Module.mockImplementationOnce(() => ({someFn: mock2}));

testFn();
expect(mock2).toHaveBeenCalled();
Expand Down Expand Up @@ -538,7 +538,7 @@ describe('moduleMocker', () => {
it('should recognize a mocked function', () => {
const mockFn = moduleMocker.fn();

expect(moduleMocker.isMockFunction(() => { })).toBe(false);
expect(moduleMocker.isMockFunction(() => {})).toBe(false);
expect(moduleMocker.isMockFunction(mockFn)).toBe(true);
});

Expand Down Expand Up @@ -593,9 +593,9 @@ describe('moduleMocker', () => {

const spy = moduleMocker.spyOn(obj, 'method');

const thisArg = { this: true };
const firstArg = { first: true };
const secondArg = { second: true };
const thisArg = {this: true};
const firstArg = {first: true};
const secondArg = {second: true};
obj.method.call(thisArg, firstArg, secondArg);
expect(isOriginalCalled).toBe(true);
expect(originalCallThis).toBe(thisArg);
Expand Down Expand Up @@ -626,7 +626,7 @@ describe('moduleMocker', () => {
moduleMocker.spyOn({}, 'method');
}).toThrow();
expect(() => {
moduleMocker.spyOn({ method: 10 }, 'method');
moduleMocker.spyOn({method: 10}, 'method');
}).toThrow();
});

Expand Down Expand Up @@ -674,7 +674,7 @@ describe('moduleMocker', () => {
let originalCallArguments;
const obj = {
get method() {
return function () {
return function() {
isOriginalCalled = true;
originalCallThis = this;
originalCallArguments = arguments;
Expand All @@ -684,9 +684,9 @@ describe('moduleMocker', () => {

const spy = moduleMocker.spyOn(obj, 'method', 'get');

const thisArg = { this: true };
const firstArg = { first: true };
const secondArg = { second: true };
const thisArg = {this: true};
const firstArg = {first: true};
const secondArg = {second: true};
obj.method.call(thisArg, firstArg, secondArg);
expect(isOriginalCalled).toBe(true);
expect(originalCallThis).toBe(thisArg);
Expand Down Expand Up @@ -717,7 +717,7 @@ describe('moduleMocker', () => {
},
get property() {
return this._property;
}
},
};

const spy = moduleMocker.spyOn(obj, 'property', 'set');
Expand All @@ -740,7 +740,7 @@ describe('moduleMocker', () => {
moduleMocker.spyOn({}, 'method');
}).toThrow();
expect(() => {
moduleMocker.spyOn({ method: 10 }, 'method');
moduleMocker.spyOn({method: 10}, 'method');
}).toThrow();
});

Expand All @@ -749,12 +749,12 @@ describe('moduleMocker', () => {
let methodTwoCalls = 0;
const obj = {
get methodOne() {
return function () {
return function() {
methodOneCalls++;
};
},
get methodTwo() {
return function () {
return function() {
methodTwoCalls++;
};
},
Expand Down