Skip to content

Adding a compatibility check for using watchman #5585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Aftabnack wants to merge 3 commits into from
Closed

Adding a compatibility check for using watchman #5585

Aftabnack wants to merge 3 commits into from

Conversation

@Aftabnack
Copy link
Contributor

@Aftabnack Aftabnack commented Feb 16, 2018

@thymikee
Copy link
Contributor

thymikee commented Feb 16, 2018

Currently it looks like this:

screen shot 2018-02-16 at 13 05 25

Not a best DX IMHO

@Aftabnack
Copy link
Contributor Author

Aftabnack commented Feb 16, 2018

I can improve the alignment of text

@thymikee thymikee requested a review from SimenB February 16, 2018 12:11
@cpojer
Copy link
Member

cpojer commented Feb 26, 2018

I think a more comprehensive fix is needed to make sure this looks good like @thymikee pointed out. Would you be able to work on that?

@Aftabnack
Copy link
Contributor Author

Aftabnack commented Feb 26, 2018

I can't work on this, I cannot test it.

@Aftabnack Aftabnack closed this Feb 26, 2018
@Aftabnack Aftabnack deleted the watchman-compat-check branch February 26, 2018 09:37
niieani added a commit to niieani/jest that referenced this pull request Apr 16, 2018
@niieani
fix(treeProcessor): revert a small change from the jestjs#5585 refact…
c682ca3 
…oring

fixes jestjs#5964
moves the `wrapChildren` into higher scope to restore undocumented execution order
@niieani niieani mentioned this pull request Apr 16, 2018
Merged
cpojer pushed a commit that referenced this pull request Apr 17, 2018
@niieani @cpojer
fix(treeProcessor): revert a small change from the #5585 refactoring (#…
bf654e1 
…6006)

fixes #5964
moves the `wrapChildren` into higher scope to restore undocumented execution order
@github-actions
Copy link

github-actions bot commented May 12, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SimenB SimenB Awaiting requested review from SimenB

Assignees

No one assigned

Labels

CLA Signed ✔️

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Jest is missing watchman version compatibility checks

4 participants

@Aftabnack @thymikee @cpojer @facebook-github-bot