Skip to content

Adding a compatibility check for using watchman #5585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Aftabnack wants to merge 3 commits into from
Closed

Adding a compatibility check for using watchman #5585

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adf51dd
Adding a compatibility check for using watchman
Aftabnack Feb 16, 2018
fea49b4
Better text formatting
Aftabnack Feb 16, 2018
c56a1bc
Play nice with prettier
Aftabnack Feb 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Play nice with prettier
  • Loading branch information
@Aftabnack
Aftabnack committed Feb 16, 2018
commit c56a1bcce9c414f53af743c5fc859956ba2818ce
5 changes: 4 additions & 1 deletion packages/jest-haste-map/src/crawlers/watchman.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ module.exports = function watchmanCrawl(
if (err) {
//Error out or Log warning?
//https://facebook.github.io/watchman/docs/cmd/watch-project.html
reject(`You seem to have an older version of watchman installed. Please install version 3.1 or later`);
reject(
'You seem to have an older version of watchman installed. ' +
'Please install version 3.1 or later.\n',
);
}
});
client.on('error', error => reject(error));
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-haste-map/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@ class HasteMap extends EventEmitter {
`empty \`.watchmanconfig\` file in your project's root folder or ` +
`initialize a git or hg repository in your project.\n` +
` ` +
error + '\n',
error,
);
return nodeCrawl({
data: hasteMap,
Expand Down