Skip to content

Check watch plugins for key conflicts #6697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 7 commits into from
Aug 9, 2018
Merged

Check watch plugins for key conflicts #6697

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e1f7be6
Watch plugins now are checked for key conflicts…
tdd Jul 15, 2018
4df6a73
copy(watch plugins): document key conflict management
tdd Jul 18, 2018
3f3422c
copy: address wording issues raised by @rogeliog in PR review
tdd Jul 18, 2018
848bfe4
refactor: rely on ValidationError for watch plugin key conflicts
tdd Jul 26, 2018
34474f9
style: made lint happy
tdd Jul 26, 2018
24cf0dc
update changelog
thymikee Aug 8, 2018
5f92d32
Merge branch 'master' into feat/watch-plugin-key-conflicts
thymikee Aug 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update changelog
  • Loading branch information
@thymikee
thymikee committed Aug 8, 2018
commit 24cf0dc875e238fe2565fd84329c29d21f7081dd
5 changes: 1 addition & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- `[jest-runner]` print stack trace when `process.exit` is called from user code ([#6714](https://github.com/facebook/jest/pull/6714))
- `[jest-each]` introduces `%#` option to add index of the test to its title ([#6414](https://github.com/facebook/jest/pull/6414))
- `[pretty-format]` Support serializing `DocumentFragment` ([#6705](https://github.com/facebook/jest/pull/6705))
- `[jest-cli]` Check watch plugins for key conflicts ([#6697](https://github.com/facebook/jest/pull/6697))

### Fixes

Expand All @@ -20,10 +21,6 @@

- `[jest-changed-files]` limit git and hg commands to specified roots ([#6732](https://github.com/facebook/jest/pull/6732))

### Features

- `[jest-cli]` Watch plugin key registrations are now checked for conflicts. Some built-in keys, such as `p` and `t` for test limitation, are overridable, but most built-in keys are reserved (e.g. `q`, `a` or `o`), and any key registered by a third-party plugin cannot be overriden by another third-party plugin. Explicit validation errors are then triggered.

### Fixes

- `[jest-circus]` Fix retryTimes so errors are reset before re-running ([#6762](https://github.com/facebook/jest/pull/6762))
Expand Down