Skip to content

Check watch plugins for key conflicts #6697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 7 commits into from
Aug 9, 2018
Merged

Check watch plugins for key conflicts #6697

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e1f7be6
Watch plugins now are checked for key conflicts…
tdd Jul 15, 2018
4df6a73
copy(watch plugins): document key conflict management
tdd Jul 18, 2018
3f3422c
copy: address wording issues raised by @rogeliog in PR review
tdd Jul 18, 2018
848bfe4
refactor: rely on ValidationError for watch plugin key conflicts
tdd Jul 26, 2018
34474f9
style: made lint happy
tdd Jul 26, 2018
24cf0dc
update changelog
thymikee Aug 8, 2018
5f92d32
Merge branch 'master' into feat/watch-plugin-key-conflicts
thymikee Aug 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style: made lint happy
  • Loading branch information
@tdd @thymikee
tdd authored and thymikee committed Aug 8, 2018
commit 34474f92bc57c6302491d3f911cc9fe632f314a7
1 change: 0 additions & 1 deletion packages/jest-cli/src/__tests__/watch.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,6 @@ describe('Watch mode flows', () => {
});

describe('when dealing with potential watch plugin key conflicts', () => {

it.each`
key | plugin
${'q'} | ${'Quit'}
Expand Down