Open
Conversation
Incremental builds have gotten painfully slow since I set `opt-level=1` in cb81f0e. They take around 3 minutes for me on a pretty fast machine. Let's go back to using the default opt-level of 0 in the dev profile and use an opt-level of 1 only in CI tests.
Contributor
|
Yes please 😀 |
Comment on lines
-171
to
-174
| [profile.dev] | ||
| # Opt-level 0 tends to run out of stack on Windows when running async code | ||
| opt-level = 1 | ||
|
|
Member
There was a problem hiding this comment.
Shouldn't this at least be conditionalized on Windows? Also, maybe by moving all our dependencies to opt-level=3 (ref #9009) we might get better stack usage through some inter-crate optimizations? I'm not sure. Maybe you can just try deleting this?
Contributor
There was a problem hiding this comment.
Maybe Windows users would want to increase the stack size than waiting for slow compilation?
BTW, I feel the opt-level=3 change also impacted build time, but I haven't measured the difference.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incremental builds have gotten painfully slow since I set
opt-level=1in cb81f0e. They take around 3 minutes for me on a pretty fast machine. Let's go back to using the default opt-level of 0 in the dev profile and use an opt-level of 1 only in CI tests.Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)how it works, how it's organized), including any code drafted by AI
eye towards deleting anything that is irrelevant, clarifying anything that
is confusing, and adding details that are relevant. This includes, for
example, commit descriptions, PR descriptions, and code comments.