Skip to content

build: set opt-level to 1 only in CI #9061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martinvonz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: set opt-level to 1 only in CI #9061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ jobs:
- name: Test
run: >-
cargo nextest run
--cargo-profile ci-test
--config .cargo/config-ci.toml
--workspace
--all-targets
Expand Down
9 changes: 5 additions & 4 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,6 @@ while_let_loop = "warn"
let_underscore_drop = "warn"
redundant_imports = "warn"

[profile.dev]
# Opt-level 0 tends to run out of stack on Windows when running async code
opt-level = 1

Comment on lines -171 to -174
Copy link
Member

@thoughtpolice thoughtpolice Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this at least be conditionalized on Windows? Also, maybe by moving all our dependencies to opt-level=3 (ref #9009) we might get better stack usage through some inter-crate optimizations? I'm not sure. Maybe you can just try deleting this?

Copy link
Contributor

@yuja yuja Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Windows users would want to increase the stack size than waiting for slow compilation?

BTW, I feel the opt-level=3 change also impacted build time, but I haven't measured the difference.

[profile.dev.package."*"]
# Compile all dependencies with opt-level=3 to help speed up tests and
# debug builds
Expand All @@ -182,3 +178,8 @@ opt-level = 3
[profile.release]
strip = "debuginfo"
codegen-units = 1

[profile.ci-test]
inherits = "test"
# Opt-level 0 tends to run out of stack on Windows when running async code
opt-level = 1
Loading