Skip to content

fix 280#935

Merged
davidanthoff merged 1 commit intomasterfrom
jmd
May 7, 2021
Merged

fix 280#935
davidanthoff merged 1 commit intomasterfrom
jmd

Conversation

@ZacLN
Copy link
Copy Markdown
Contributor

@ZacLN ZacLN commented May 7, 2021

Fixes julia-vscode/StaticLint.jl#280

Previously we were pushing arguments to the top expresions .args field directly, rather than using the specialised push!(expr::EXPR,item). The specialised version makes sure the parent of each item is set to expr.

For every PR, please check the following:

@ZacLN ZacLN added the bug label May 7, 2021
@ZacLN ZacLN added this to the Next Patch milestone May 7, 2021
@ZacLN ZacLN requested a review from a team May 7, 2021 13:36
Copy link
Copy Markdown
Member

@pfitzseb pfitzseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this fixes the issue.

@davidanthoff davidanthoff merged commit 52dd52a into master May 7, 2021
@davidanthoff davidanthoff deleted the jmd branch May 7, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken scopes in JMDs

3 participants