additional checks for delayed scope retrieval#281
Closed
Conversation
ZacLN
approved these changes
May 7, 2021
Contributor
ZacLN
left a comment
There was a problem hiding this comment.
I'd prefer to fix the root issue as I think there are other areas where I make the assumption that a scope can be retrieved from any given EXPR... but I can't replicate this on my machine (with the code in the attached issue) so happy for this to go in for now
Member
Author
|
I could repro that issue locally, but only in a jmd context, so when processed via https://github.com/julia-vscode/LanguageServer.jl/blob/5284d8f3778906d7d5d0ccb96b884403f35b387d/src/requests/textdocument.jl#L247 |
Contributor
|
Ah - I think it wasn't working without the file being saved, it seems to be crashing now |
Contributor
|
I think julia-vscode/LanguageServer.jl#935 should fix it - could you check? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents a LS crash with certain JMD files (see #280), but doesn't fix the cause of the issue.
For every PR, please check the following: