Skip to content

additional checks for delayed scope retrieval#281

Closed
pfitzseb wants to merge 2 commits intomasterfrom
sp/delayed-scope-checks
Closed

additional checks for delayed scope retrieval#281
pfitzseb wants to merge 2 commits intomasterfrom
sp/delayed-scope-checks

Conversation

@pfitzseb
Copy link
Copy Markdown
Member

This prevents a LS crash with certain JMD files (see #280), but doesn't fix the cause of the issue.

For every PR, please check the following:

@pfitzseb pfitzseb requested a review from ZacLN April 28, 2021 14:20
@davidanthoff davidanthoff added this to the Next Patch milestone May 5, 2021
Copy link
Copy Markdown
Contributor

@ZacLN ZacLN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to fix the root issue as I think there are other areas where I make the assumption that a scope can be retrieved from any given EXPR... but I can't replicate this on my machine (with the code in the attached issue) so happy for this to go in for now

@pfitzseb
Copy link
Copy Markdown
Member Author

pfitzseb commented May 7, 2021

I could repro that issue locally, but only in a jmd context, so when processed via https://github.com/julia-vscode/LanguageServer.jl/blob/5284d8f3778906d7d5d0ccb96b884403f35b387d/src/requests/textdocument.jl#L247

@ZacLN
Copy link
Copy Markdown
Contributor

ZacLN commented May 7, 2021

Ah - I think it wasn't working without the file being saved, it seems to be crashing now

@ZacLN
Copy link
Copy Markdown
Contributor

ZacLN commented May 7, 2021

I think julia-vscode/LanguageServer.jl#935 should fix it - could you check?

@pfitzseb pfitzseb closed this May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants