Skip to content

Conversation

@gabrieldemarmiesse
Copy link
Contributor

@gabrieldemarmiesse gabrieldemarmiesse commented Aug 30, 2018

Summary

Revert #10995 since the timeout is not related to a keras test in particular.
The timeout isn't useful.

Related Issues

PR Overview

  • This PR requires new unit tests [y/n] (make sure tests are included)
  • This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
  • This PR is backwards compatible [y/n]
  • This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

@fchollet
Copy link
Collaborator

The timeout isn't useful.

I think it would be useful to restart on timeout the tests that are causing the timeout, which are most likely tests related to Sequence/etc.

@gabrieldemarmiesse
Copy link
Contributor Author

You mean all tests using multiprocessing?

@fchollet
Copy link
Collaborator

I think the problem is likely not all tests related to multiprocessing. There's probably a small number of tests that cause the issue.

You can try to find them by looking at which tests do not get logged as passing in the past few failing builds (compare to the list of passing tests for a successful build).

@gabrieldemarmiesse
Copy link
Contributor Author

I'll see if I can find something then by looking at the logs. Give me some time. I'll close this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants