Skip to content

Conversation

@gabrieldemarmiesse
Copy link
Contributor

Summary

@taehoonlee
Follow-up on #11037
Still trying to make those tests look younger and prettier.

Related Issues

PR Overview

  • This PR requires new unit tests [y/n] (make sure tests are included)
  • This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
  • This PR is backwards compatible [y/n]
  • This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

@gabrieldemarmiesse
Copy link
Contributor Author

I got a weird error unrelated to my PR:

=================================== FAILURES ===================================
______________________ test_generator_enqueuer_threadsafe ______________________
[gw1] linux2 -- Python 2.7.15 /home/travis/miniconda/envs/test-environment/bin/python
    def test_generator_enqueuer_threadsafe():
        enqueuer = GeneratorEnqueuer(create_generator_from_sequence_pcs(
            DummySequence([3, 200, 200, 3])), use_multiprocessing=False)
        enqueuer.start(3, 10)
        gen_output = enqueuer.get()
        with pytest.raises(RuntimeError) as e:
>           [next(gen_output) for _ in range(10)]
E           Failed: DID NOT RAISE <type 'exceptions.RuntimeError'>
tests/keras/utils/data_utils_test.py:207: Failed

Maybe it's related to #11034 ?

In any case, re-trigerring the tests.

@taehoonlee
Copy link
Contributor

LGTM. And @gabrieldemarmiesse, I would like you to remind that the motivation of these PRs is not only simple style improvements but also CI build time reductions.

@taehoonlee taehoonlee merged commit 6f53d0a into keras-team:master Sep 1, 2018
jlherren added a commit to jlherren/keras that referenced this pull request Sep 3, 2018
* keras/master: (327 commits)
  Added in_train_phase and in_test_phase in the numpy backend. (keras-team#11061)
  Make sure the data_format argument defaults to ‘chanels_last’ for all 1D sequence layers.
  Speed up backend tests (keras-team#11051)
  Skipped some duplicated tests. (keras-team#11049)
  Used decorators and WITH_NP to avoid tests duplication. (keras-team#11050)
  Cached the theano compilation directory. (keras-team#11048)
  Removing duplicated backend tests. (keras-team#11037)
  [P, RELNOTES] Conv2DTranspose supports dilation (keras-team#11029)
  Doc Change: Change in shape for CIFAR Datasets (keras-team#11043)
  Fix line too long in mnist_acgan (keras-team#11040)
  Enable using last incomplete minibatch (keras-team#8344)
  Better UX (keras-team#11039)
  Update lstm text generation example (keras-team#11038)
  fix a bug, load_weights doesn't return anything (keras-team#11031)
  Speeding up the tests by reducing the number of K.eval(). (keras-team#11036)
  [P] Expose monitor value getter for easier subclass (keras-team#11002)
  [RELNOTES] Added the mode "bilinear" in the upscaling2D layer. (keras-team#10994)
  Separate pooling test from convolutional test and parameterize test case (keras-team#10975)
  Fix issue with non-canonical TF version name format.
  Allow TB callback to display float values.
  ...
@gabrieldemarmiesse gabrieldemarmiesse deleted the use_K branch September 18, 2018 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants