Skip to content

✨ bump CR to v0.5.0 and CT to v0.2.5 #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2020
Merged

✨ bump CR to v0.5.0 and CT to v0.2.5 #1391

merged 1 commit into from
Feb 28, 2020

Conversation

@mengqiy
Copy link
Member

@mengqiy mengqiy commented Feb 26, 2020 •
edited
Loading

This PR needs #1394.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 26, 2020
@mengqiy mengqiy added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2020
@mengqiy mengqiy changed the title ✨ bump CR to v0.5.0 and CT to v0.2.5 WIP ✨ bump CR to v0.5.0 and CT to v0.2.5 Feb 26, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2020
@mengqiy mengqiy mentioned this pull request Feb 27, 2020
Merged
Adirio
Adirio approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@Adirio Adirio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mengqiy mengqiy changed the title WIP ✨ bump CR to v0.5.0 and CT to v0.2.5 ✨ bump CR to v0.5.0 and CT to v0.2.5 Feb 28, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2020
@mengqiy mengqiy removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2020
@mengqiy mengqiy closed this Feb 28, 2020
@mengqiy mengqiy reopened this Feb 28, 2020
@mengqiy
Copy link
Member Author

mengqiy commented Feb 28, 2020

This is ready to go. And then we can do a release.

@mengqiy
Copy link
Member Author

mengqiy commented Feb 28, 2020

/retest

@droot droot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit 800f63a into kubernetes-sigs:master Feb 28, 2020
@mengqiy mengqiy deleted the bumpCRCT branch February 28, 2020 18:53
@Adirio Adirio mentioned this pull request Mar 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

2 more reviewers

@droot droot droot approved these changes

@Adirio Adirio Adirio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mengqiy @k8s-ci-robot @droot @Adirio