Include the missing envtest import.

[caiges]

Fixes #1416

This change includes the addition of a missing import, "sigs.k8s.io/controller-runtime/pkg/envtest" in the scaffold file controllers/suite_test.go.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @caiges!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @caiges. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Adirio]

Please follow the CLA instructions posted by the bot: #1417 (comment)

/ok-to-test
/lgtm

[caiges]

/check-cla

[caiges]

I signed it

[caiges]

/check-cla

[camilamacedo86]

Hi @caiges,

We use a script called which runs the tool commands to scaffold a mock testdata. To generate it properly, I would suggest using the target make generate. To check it better see the CONTRIBUTING doc.

However, note that this PR is passing in the CI and no changes were made in this mock testadata files.
Also, I was unable to reproduce it using the master. So, IHMO before merging this one we need to check the scenario and add the command to the golden script and see this change reflect in the mock data.

@Adirio,

Could you reproduce this one?

PS.: I saw in the issue that you are using go version 1.14 and the kubebuilder was not upgraded to use it. So, you need to use 1.13+ < 1.14.

[Adirio]

Hi @camilamacedo86

However, note that this PR is passing in the CI and no changes were made in this mock testadata files.
Also, I was unable to reproduce it using the master. So, IHMO before merging this one we need to check the scenario and add the command to the golden script and see this change reflect in the mock data.

@Adirio,

Could you reproduce this one?

Files, before being scaffolded, are passed through go imports programatically. In most cases that adds the import he is adding manually but in his case his scaffolder is not adding it (not sure why his isn't adding it). However, the import should have been there in the first place, it was removed in a previous PR by mistake (#1391). You can check how the generated controller suite tests under testdata do have that import and add the new one, but the template replaces it by the new import when both are needed.

Off-topic:

PS.: I saw in the issue that you are using go version 1.14 and the kubebuilder was not upgraded to use it. So, you need to use 1.13+ < 1.14.

I'm using kubebuilder with 1.14 successfully, despite we still have no official support for it in the tests.

[camilamacedo86]

Hi @Adirio,

I could check that the testdata has the import. (E.g https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v2-multigroup/controllers/crew/suite_test.go#L28)
and confirmed that we are using the v2 template to do the scaffold

Also, since you could indeed identify that it was removed by mistake here shows that all is ok for we move forward with.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caiges, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[christopherhein]

@camilamacedo86 @DirectXMan12 @Adirio any chance we can get a patch release with this fix, 2.3 was released 25+ days ago and this was fixed 19 days ago and it's kind of a bad first user experience to have to fix the test suite for a missing import.

[camilamacedo86]

I am not sure If I have permission to do the releases. I think @mengqiy can help us with.

[mengqiy]

https://github.com/kubernetes-sigs/kubebuilder/releases/tag/v2.3.1 has been released.
@camilamacedo86 @Adirio Can you please work together to ensure the new doc changes are picked up in our production branch for doc which isbook-v2? I guess the thing need to do is to create a PR to fast-forward all the commits from v2.3.1 to branch book-v2.