-
Notifications
You must be signed in to change notification settings - Fork 1.6k
🌱 update refs to go-test make target #2138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Should be make test-unit now as of kubernetes-sigs@8c08161#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L90 Signed-off-by: Michelle Noorali <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:ghost: is not understood, use :seedling:.
There are more changes to do to this section but you are right with this change.
/kind documentation
camilamacedo86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, michelleN The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
HI @Adirio, I this case we can update to help the contributor. So, that is done 👍
|
Thanks @camilamacedo86 and @Adirio - please let me know if I need to do anything else/make any changes! |
|
/test pull-kubebuilder-e2e-k8s-1-15-12 |
8c08161#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L90
Signed-off-by: Michelle Noorali [email protected]