Skip to content

Conversation

@michelleN
Copy link

Signed-off-by: Michelle Noorali [email protected]

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 9, 2021
@k8s-ci-robot k8s-ci-robot requested review from droot and pwittrock April 9, 2021 21:11
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 9, 2021
Adirio
Adirio previously requested changes Apr 10, 2021
Copy link
Contributor

@Adirio Adirio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:ghost: is not understood, use :seedling:.

There are more changes to do to this section but you are right with this change.

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 10, 2021
@Adirio Adirio added the testing label Apr 10, 2021
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, michelleN

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 12, 2021
@camilamacedo86 camilamacedo86 changed the title 👻 update refs to go-test make target 🌱 update refs to go-test make target Apr 12, 2021
@camilamacedo86 camilamacedo86 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2021
@camilamacedo86 camilamacedo86 requested a review from Adirio April 12, 2021 13:31
@camilamacedo86 camilamacedo86 dismissed Adirio’s stale review April 12, 2021 13:32

HI @Adirio, I this case we can update to help the contributor. So, that is done 👍

@michelleN
Copy link
Author

michelleN commented Apr 12, 2021

Thanks @camilamacedo86 and @Adirio - please let me know if I need to do anything else/make any changes!

@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-15-12

@k8s-ci-robot k8s-ci-robot merged commit 3748512 into kubernetes-sigs:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants