Skip to content

🌱 update refs to go-test make target #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2021
Merged

🌱 update refs to go-test make target #2138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
👻 update refs to go-test make target 
* Should be make test-unit now as of
8c08161#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L90

Signed-off-by: Michelle Noorali <[email protected]>
  • Loading branch information
Michelle Noorali committed Apr 9, 2021
commit 8c59e1fee8432bfce02b309e794c98423b34a951
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ $ git clone [email protected]:<user>/kubebuilder.git $GOPATH/src/sigs.k8s.io/kubebu
1. Ensure you activate module support before continue (`$ export GO111MODULE=on`)
1. Run the command `make install` to create a bin with the source code

**NOTE** In order to check the local environment run `make go-test`.
**NOTE** In order to check the local environment run `make test-unit`.

## What to do before submitting a pull request

Expand All @@ -49,7 +49,7 @@ Following the targets that can be used to test your changes locally.

| Command | Description | Is called in the CI? |
|--- |--- |--- |
| make go-test | Runs go tests | no |
| make test-unit | Runs go tests | no |
| make test| Runs tests in shell (`./test.sh`) | yes |
| make lint | Run [golangci][golangci] lint checks | yes |
| make lint-fix | Run [golangci][golangci] to automatically perform fixes | no |
Expand Down