-
Notifications
You must be signed in to change notification settings - Fork 1.6k
✨ add support for go1.19, update envtest version to use k8s 1.25 #2911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: oscr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@oscr: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| go 1.18 | ||
| go 1.19 | ||
|
|
||
| require ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camilamacedo86 A side question. Kubebuilder seems to have updated to ginkov2, but the testdata is still github.com/onsi/ginkgo v1.16.5. Should this be updated? And if so where?
|
Is it needed to use modules for k8s v1.25 in If so, it needs to update multiple Or, it aims to just update k8s version for envtest only? |
| // Variables and function to check Go version requirements. | ||
| var ( | ||
| goVerMin = golang.MustParse("go1.17.9") | ||
| goVerMin = golang.MustParse("go1.18") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oscr I think the problem here is that we need to put the value with 0. So, it needs to be 1.18.0
|
@oscr: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
Based on #2714