Skip to content

Conversation

@oscr
Copy link
Contributor

@oscr oscr commented Sep 6, 2022

Description

  • Update to go1.19
  • Update envtest version for k8s 1.25
  • Update goreleaser: v1.11.2

Based on #2714

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oscr
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval by writing /assign @camilamacedo86 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 6, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2022
@k8s-ci-robot
Copy link
Contributor

@oscr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubebuilder-test a356ff3 link true /test pull-kubebuilder-test
pull-kubebuilder-e2e-k8s-1-18-20 a356ff3 link false /test pull-kubebuilder-e2e-k8s-1-18-20
pull-kubebuilder-e2e-k8s-1-21-2 a356ff3 link false /test pull-kubebuilder-e2e-k8s-1-21-2
pull-kubebuilder-e2e-k8s-1-20-7 a356ff3 link false /test pull-kubebuilder-e2e-k8s-1-20-7
pull-kubebuilder-e2e-k8s-1-19-16 a356ff3 link false /test pull-kubebuilder-e2e-k8s-1-19-16

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

go 1.18
go 1.19

require (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camilamacedo86 A side question. Kubebuilder seems to have updated to ginkov2, but the testdata is still github.com/onsi/ginkgo v1.16.5. Should this be updated? And if so where?

@atoato88
Copy link
Contributor

atoato88 commented Sep 6, 2022

Is it needed to use modules for k8s v1.25 in go.mod files on this PR?
e.g:
Updated go.mod file in this PR remains to have k8s.io/apimachinery as v0.24.2.
Should we use as v0.25.0 like following:

k8s.io/apimachinery v0.25.0

If so, it needs to update multiple go.mod files in same manner.

Or, it aims to just update k8s version for envtest only?

// Variables and function to check Go version requirements.
var (
goVerMin = golang.MustParse("go1.17.9")
goVerMin = golang.MustParse("go1.18")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oscr I think the problem here is that we need to put the value with 0. So, it needs to be 1.18.0

@k8s-ci-robot
Copy link
Contributor

@oscr: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants