-
Notifications
You must be signed in to change notification settings - Fork 1.6k
✨ add support to go 1.19 #2922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add support to go 1.19 #2922
Conversation
4a58252 to
aa80ddb
Compare
|
@oscr you'll have to run |
aa80ddb to
9186b74
Compare
|
Blocked until this is merged kubernetes/test-infra#27395 |
|
@jmrodri Thank you for your advice 🙏 |
camilamacedo86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @oscr,
Thank you for the contribution 🥇 .
I hope that you do not mind.
I just update the title so we move forward because updating goreleaser is something that does not matter for those that use the tool.
In the changelog which is generated automatically, we just add the changes that can impact the CLI users and those that are consumers of the lib.
/lgtm
/approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, oscr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pull-kubebuilder-e2e-k8s-1-19-16 |
|
/test pull-kubebuilder-test |
|
/test pull-kubebuilder-e2e-k8s-1-19-16 |
|
/test pull-kubebuilder-test |
|
/hold cancel |
|
Thank you for cleaning up the pr @camilamacedo86. 🚀 I was unaware of the autogenerated changelog. |
Updates:
Related pr #2920 Update controller-runtime, kubebuilder-declarative...
But separating the Golang update for the rest