Skip to content

Conversation

@oscr
Copy link
Contributor

@oscr oscr commented Sep 10, 2022

Updates:

  • go1.18/go1.17 -> go1.19
  • goreleaser 1.9.2 -> 1.11.2

Related pr #2920 Update controller-runtime, kubebuilder-declarative...
But separating the Golang update for the rest

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 10, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 10, 2022
@jmrodri
Copy link
Contributor

jmrodri commented Sep 10, 2022

@oscr you'll have to run make generate to fix the testdata.

@oscr
Copy link
Contributor Author

oscr commented Sep 10, 2022

Blocked until this is merged kubernetes/test-infra#27395

@oscr
Copy link
Contributor Author

oscr commented Sep 10, 2022

@jmrodri Thank you for your advice 🙏

@camilamacedo86 camilamacedo86 changed the title ✨ Update to Go 1.19 and goreleaser 1.11.2 ✨ add support to go 1.19 Sep 10, 2022
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @oscr,

Thank you for the contribution 🥇 .
I hope that you do not mind.
I just update the title so we move forward because updating goreleaser is something that does not matter for those that use the tool.

In the changelog which is generated automatically, we just add the changes that can impact the CLI users and those that are consumers of the lib.

/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, oscr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2022
@camilamacedo86
Copy link
Member

/pull-kubebuilder-e2e-k8s-1-19-16

@camilamacedo86
Copy link
Member

/test pull-kubebuilder-test

@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-19-16

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2022
@camilamacedo86
Copy link
Member

/test pull-kubebuilder-test

@camilamacedo86
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit c2236c3 into kubernetes-sigs:master Sep 10, 2022
@oscr oscr deleted the upgrade-go1.19 branch September 11, 2022 08:56
@oscr
Copy link
Contributor Author

oscr commented Sep 11, 2022

Thank you for cleaning up the pr @camilamacedo86. 🚀 I was unaware of the autogenerated changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants