Skip to content

feat(controls): Add IsTopSeparatorVisible and IsFooterSeparatorVisible properties to NavigationView component #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pomianowski merged 3 commits into from
Nov 7, 2025
Merged

feat(controls): Add IsTopSeparatorVisible and IsFooterSeparatorVisible properties to NavigationView component #1464

pomianowski merged 3 commits into from
Nov 7, 2025

Conversation

@evandrofadul
Copy link
Contributor

@evandrofadul evandrofadul commented Jun 27, 2025 •
edited
Loading

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

The NavigationView component has a separator at the top and another at the footer, but it is not possible to hide both.

Issue Number: N/A

What is the new behavior?

  • Added IsTopSeparatorVisible property for NavigationView component.
  • Added IsFooterSeparatorVisible property for NavigationView component.

Other information

BkGfuuz38D

@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. styles Topic is related to styles PR Pull request navigation Changes to navigation related controls. dotnet release labels Jun 27, 2025
@Nuklon
Copy link
Collaborator

Nuklon commented Jul 1, 2025

I recommend to split this up so you can control both.

@evandrofadul evandrofadul changed the title Add IsTopAndFooterSeparatorVisible property to NavigationView component Add IsTopSeparatorVisible and IsFooterSeparatorVisible properties to NavigationView component Jul 1, 2025
@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Jul 8, 2025
@github-actions github-actions bot mentioned this pull request Jul 8, 2025
Open
@pomianowski pomianowski changed the title Add IsTopSeparatorVisible and IsFooterSeparatorVisible properties to NavigationView component feat(controls): Add IsTopSeparatorVisible and IsFooterSeparatorVisible properties to NavigationView component Nov 7, 2025
@pomianowski pomianowski merged commit 7316830 into lepoco:main Nov 7, 2025
2 checks passed
@apachezy apachezy mentioned this pull request Nov 8, 2025
Merged
7 tasks
This was referenced Nov 24, 2025
Merged
Closed
Merged
This was referenced Dec 2, 2025
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pomianowski pomianowski pomianowski approved these changes

Assignees

No one assigned

Labels

controls Changes to the appearance or logic of custom controls. dotnet navigation Changes to navigation related controls. PR Pull request release ⭐ top pull request Top pull request. styles Topic is related to styles

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evandrofadul @Nuklon @pomianowski