Skip to content

Conversation

@apachezy
Copy link
Contributor

@apachezy apachezy commented Nov 8, 2025

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

  • The Separator (Border) did not have a border brush set but had a border thickness > 0, which could make the border occupy space but remain invisible.
  • The top and bottom border thickness of the Separator (Border) was 0.5 each, exactly filling the height of a 1-unit Border, preventing the background from showing.

Issue Number: N/A

What is the new behavior?

  • The separators render correctly.

Other information

The issue seems to have originated from #1541, which attempted to fix #1514 but didn’t address the root cause.
This PR corrects the rendering logic to align with the intended design.
Note: #1514 has already been resolved by #1464.

@apachezy apachezy requested a review from pomianowski as a code owner November 8, 2025 21:21
@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. styles Topic is related to styles PR Pull request navigation Changes to navigation related controls. release labels Nov 8, 2025
@pomianowski pomianowski merged commit 43862ee into lepoco:main Nov 9, 2025
2 checks passed
@apachezy apachezy deleted the fix/nav-view-separator branch November 9, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

controls Changes to the appearance or logic of custom controls. navigation Changes to navigation related controls. PR Pull request release styles Topic is related to styles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NavigationView Bug: Unexpected separators and menu item jumping behavior

2 participants