Skip to content

Conversation

@roelvandergoot
Copy link

@roelvandergoot roelvandergoot commented Oct 14, 2020

  • Added a test and a fix for handling empty result sets.
  • Had to set res.tag to prevent another test from failing.
  • Not sure what the purpose of this test is. Would prefer to remove both the clearing of res.tag and the offending test (commit 2).
  • Preferably, I would merge both commits, but if the offending test is somehow important we can merge only the first commit.
  • Issue: Empty result sets are handled incorrectly #1003

@jba
Copy link

jba commented Oct 16, 2020

Can we get this to land? I'm having the same issue.

@roelvandergoot
Copy link
Author

roelvandergoot commented Oct 20, 2020

@jba: Can you replace your github.com/lib/pq imports with github.com/roelvandergoot/pq and see if this solves your problem? Thank you!

I am no longer seeing this problem in my testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants