Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Handle empty result sets
  • Loading branch information
Roel van der Goot committed Oct 14, 2020
commit 4c8c217da681ae63bbd7713e3dc975113770fcac
6 changes: 5 additions & 1 deletion conn.go
Original file line number Diff line number Diff line change
Expand Up @@ -663,8 +663,12 @@ func (cn *conn) simpleQuery(q string) (res *rows, err error) {
// Set the result and tag to the last command complete if there wasn't a
// query already run. Although queries usually return from here and cede
// control to Next, a query with zero results does not.
if t == 'C' && res.colNames == nil {
if t == 'C' {
res.result, res.tag = cn.parseComplete(r.string())
if res.colNames != nil {
res.tag = ""
return
}
}
res.done = true
case 'Z':
Expand Down
30 changes: 30 additions & 0 deletions conn_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1748,6 +1748,36 @@ func TestMultipleResult(t *testing.T) {
}
}

func TestMultipleEmptyResult(t *testing.T) {
db := openTestConn(t)
defer db.Close()

rows, err := db.Query("select 1 where false; select 2")
if err != nil {
t.Fatal(err)
}
defer rows.Close()

for rows.Next() {
t.Fatal("unexpected row")
}
if !rows.NextResultSet() {
t.Fatal("expected more result sets", rows.Err())
}
for rows.Next() {
var i int
if err := rows.Scan(&i); err != nil {
t.Fatal(err)
}
if i != 2 {
t.Fatalf("expected 2, got %d", i)
}
}
if rows.NextResultSet() {
t.Fatal("unexpected result set")
}
}

func TestCopyInStmtAffectedRows(t *testing.T) {
db := openTestConn(t)
defer db.Close()
Expand Down