keystore: remove mutex #1147
Merged
keystore: remove mutex #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gammazero
reviewed
Sep 10, 2025
guillaumemichel
commented
Sep 10, 2025
|
Since the supplied datastore is considered to be thread safe, we can safely remove the mutex without running all datastore operations sequentially in a single go routine, like implemented in this PR. EDIT: A mutex is still required in the |
hsanjuan
approved these changes
Sep 12, 2025
guillaumemichel
force-pushed
the
provider-accelerate-keystore
branch
from
74670b4 to
bb7a2d4
Compare
guillaumemichel
force-pushed
the
provider-accelerate-keystore
branch
from
bb7a2d4 to
38a707a
Compare
gammazero
approved these changes
Sep 16, 2025
guillaumemichel
force-pushed
the
provider-accelerate-keystore
branch
from
c45a22e to
bfc6664
Compare
guillaumemichel
added a commit
to guillaumemichel/go-libp2p-kad-dht
that referenced
this pull request
Sep 17, 2025
* provider: ResettableKeyStore * keystore: remove mutex * use datastore namespace * don't sync to write to altDs * simplify put * deduplicate operation execution code
guillaumemichel
added a commit
to guillaumemichel/go-libp2p-kad-dht
that referenced
this pull request
Sep 17, 2025
* provider: ResettableKeyStore * keystore: remove mutex * use datastore namespace * don't sync to write to altDs * simplify put * deduplicate operation execution code
guillaumemichel
added a commit
that referenced
this pull request
Sep 17, 2025
* provider: ResettableKeyStore * keystore: remove mutex * use datastore namespace * don't sync to write to altDs * simplify put * deduplicate operation execution code
guillaumemichel
added a commit
that referenced
this pull request
Sep 17, 2025
* provider: ResettableKeyStore * keystore: remove mutex * use datastore namespace * don't sync to write to altDs * simplify put * deduplicate operation execution code
guillaumemichel
added a commit
that referenced
this pull request
Sep 18, 2025
* provider: ResettableKeyStore * keystore: remove mutex * use datastore namespace * don't sync to write to altDs * simplify put * deduplicate operation execution code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1146
Part of #1095
Remove lock contention in
KeyStoreby having a go routine managing accesses to the underneathdatastore.This adds quite some complexity :(
cc: @gammazero @hsanjuan