Skip to content

keystore: remove mutex #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 16, 2025
Merged

keystore: remove mutex #1147

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9d30fd5
provider: ResettableKeyStore
guillaumemichel Sep 9, 2025
172e857
keystore: remove mutex
guillaumemichel Sep 10, 2025
5088386
use datastore namespace
guillaumemichel Sep 11, 2025
d154d71
don't sync to write to altDs
guillaumemichel Sep 11, 2025
38a707a
simplify put
guillaumemichel Sep 12, 2025
2f182c7
deduplicate operation execution code
guillaumemichel Sep 12, 2025
bfc6664
Merge branch 'provider' into provider-accelerate-keystore
guillaumemichel Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dual/provider/options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const (
)

type config struct {
keyStore *datastore.KeyStore
keyStore datastore.KeyStore

reprovideInterval [2]time.Duration // [0] = LAN, [1] = WAN
maxReprovideDelay [2]time.Duration
Expand Down Expand Up @@ -87,7 +87,7 @@ var DefaultConfig = func(cfg *config) error {
return nil
}

func WithKeyStore(keyStore *datastore.KeyStore) Option {
func WithKeyStore(keyStore datastore.KeyStore) Option {
return func(cfg *config) error {
if keyStore == nil {
return errors.New("provider config: keyStore cannot be nil")
Expand Down
2 changes: 1 addition & 1 deletion dual/provider/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ type SweepingProvider struct {
dht *dual.DHT
LAN *provider.SweepingProvider
WAN *provider.SweepingProvider
keyStore *datastore.KeyStore
keyStore datastore.KeyStore
}

// New creates a new SweepingProvider that manages provides and reprovides for
Expand Down
Loading
Loading