refactor: remove provider status command #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use Debugw with count field first, calculate len once
lidel
changed the title
add batchProvide entry log with prefix and count log sent records after successful sendProviderRecords put prefix first in all provider logs
reuse slice for readability
lidel
approved these changes
Sep 26, 2025
lidel
reviewed
Sep 27, 2025
| s.provideCounter.Add(s.ctx, int64(len(allKeys))) | ||
| keyCount := len(allKeys) | ||
| s.provideCounter.Add(s.ctx, int64(keyCount)) | ||
| logger.Debugw("sent provider records", "prefix", r.Prefix, "count", keyCount, "keys", allKeys) |
Member
There was a problem hiding this comment.
💭 this can get pretty hardcore in debug level, 10748 keys in one line:
2025-09-27T03:35:58.329Z DEBUG dht/provider provider/provider.go:1336 sent provider records {"prefix": "01001101", "count": 10748, "keys": ["EiB9gQIoN[...]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, we don't want to track timestamp for every provided multihash, since it adds a lot of overhead. Moreover, the feature would only benefit a small number of users, but all users need to pay the price of logging timestamps.
ProvideStatuscommand (scaffold)DEBUGso that users are able to know which multihashes were provided (with timestamp) if necessary.cc: @gammazero @lidel