Skip to content

refactor: remove provider status command #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidel merged 4 commits into from
Sep 26, 2025
Merged

refactor: remove provider status command #1157

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41591ce
remove: provider status command
guillaumemichel Sep 24, 2025
6d9fa7c
fix: use structured logging for provider records
lidel Sep 25, 2025
4b9308f
fix: log successful provides with prefix and keys
lidel Sep 26, 2025
9c719a2
refactor: create keys slice once in vanillaProvide
lidel Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
remove: provider status command
  • Loading branch information
@guillaumemichel
guillaumemichel committed Sep 24, 2025
commit 41591ce4d3c2e38f3e1dcc65ff405a266441ab19
20 changes: 1 addition & 19 deletions provider/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1339,6 +1339,7 @@ func (s *SweepingProvider) provideRegions(regions []keyspace.Region, addrInfo pe
continue
}
s.provideCounter.Add(s.ctx, int64(len(allKeys)))
logger.Debug("sent provider records for ", allKeys)
}
// If at least 1 regions was provided, we don't consider it a failure.
return errCount < len(regions)
Expand Down Expand Up @@ -1430,25 +1431,6 @@ func (s *SweepingProvider) Clear() int {
return s.provideQueue.Clear()
}

// ProvideState encodes the current relationship between this node and `key`.
type ProvideState uint8

const (
StateUnknown ProvideState = iota // we have no record of the key
StateQueued // key is queued to be provided
StateProvided // key was provided at least once
)

// ProvideStatus reports the provider’s view of a key.
//
// When `state == StateProvided`, `lastProvide` is the wall‑clock time of the
// most recent successful provide operation (UTC).
// For `StateQueued` or `StateUnknown`, `lastProvide` is the zero `time.Time`.
func (s *SweepingProvider) ProvideStatus(key mh.Multihash) (state ProvideState, lastProvide time.Time) {
// TODO: implement me
return StateUnknown, time.Time{}
}

// AddToSchedule makes sure the prefixes associated with the supplied keys are
// scheduled to be reprovided.
//
Expand Down
Loading