-
Notifications
You must be signed in to change notification settings - Fork 1.2k
core: Add support for ECDSA identities #2352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mxinden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @davxy for the pull request.
This looks good to me, though I don't think I should be the only reviewer on a crypto focused pull request.
@dignifiedquire or @burdges do you have opinions on p256 vs ring?
|
@tarcieri should be able to give a better comparison than me. |
dignifiedquire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implementation from a crypto standpoint looks good to me
thomaseizinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Some comments / discussion points.
Furthermore SecretKey can now be serialized/deserialized to/from a byte vector.
thomaseizinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
mxinden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davxy for the contribution.
Also tested with https://github.com/libp2p/rust-libp2p/blob/master/examples/ipfs-kad.rs using ECDSA identity.
|
Also thanks to @thomaseizinger and @dignifiedquire for the input! |
Closes #556
Implementation compliant with https://github.com/libp2p/specs/blob/master/peer-ids/peer-ids.md#ecdsa