Skip to content

Conversation

@davxy
Copy link
Contributor

@davxy davxy commented Nov 21, 2021

@thomaseizinger thomaseizinger changed the title Ecdsa identity core: Add support for ECDSA identities Nov 24, 2021
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @davxy for the pull request.

This looks good to me, though I don't think I should be the only reviewer on a crypto focused pull request.

@dignifiedquire or @burdges do you have opinions on p256 vs ring?

@dignifiedquire
Copy link
Member

@tarcieri should be able to give a better comparison than me.

Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation from a crypto standpoint looks good to me

Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Some comments / discussion points.

Furthermore SecretKey can now be serialized/deserialized to/from a byte
vector.
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davxy for the contribution.

Also tested with https://github.com/libp2p/rust-libp2p/blob/master/examples/ipfs-kad.rs using ECDSA identity.

@mxinden mxinden merged commit 245b056 into libp2p:master Nov 30, 2021
@mxinden
Copy link
Member

mxinden commented Nov 30, 2021

Also thanks to @thomaseizinger and @dignifiedquire for the input!

@davxy davxy deleted the ecdsa_identity branch December 20, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ECDSA public key format

4 participants