Change API to allow multiple simultaneous clients #80
Conversation
tomaka
force-pushed
the
fix-multi-connec
branch
from
6fe32f6 to
a807037
Compare
|
For the record this doesn't allow the echo example to handle multiple simultaneously clients, because the code to do so is non-trivial (requires creating a custom implementation of |
tomaka
force-pushed
the
fix-multi-connec
branch
3 times, most recently
from
75f3118 to
d545f76
Compare
tomaka
force-pushed
the
fix-multi-connec
branch
from
d545f76 to
3438640
Compare
| .and_then(move |(msg, rest)| { | ||
| if let Some(msg) = msg { | ||
| // One message has been received. We send it back to the client. | ||
| println!("Received a message from {}: {:?}\n => Sending back \ |
There was a problem hiding this comment.
Is this just for debugging now or should we bring in a logging library like the parity client, allowing users to flip some flags for extra debug data? Just a general question that I thought of when I saw this, doesn't have to be addressed in this PR obviously.
There was a problem hiding this comment.
This example is here to quickly demonstrate how to use libp2p, so I don't think a logging library is necessary.
There was a problem hiding this comment.
No definitely not, I was just talking generally, might be nice to be able to flip on something like trace messages, we can move that conversation to Riot :P
2 participants
Right now the way the
Transporttrait works is that it produces a stream of sockets over which modifiers are applied in order to negotiate a protocol. Unfortunately an overlook of this design is that elements of a stream are polled serially, and not in parallel. The consequence is that right now a server cannot accept any further client while a client is already being negotiated.This PR fixes that by changing the item yielded by the
Listenerstream from aResult<impl AsyncRead + AsyncWrite, IoError>to aimpl Future<Item = impl AsyncRead + AsyncWrite, Error = IoError>.Two notes:
dial_and_listenmethods because a general improvement of multiplexing is needed anyway.ConnectionReuseintroduced by this PR are very unsatisfactory, for the same reason.