Change the MuxedTransport trait #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
force-pushed
the
muxed-transport-change
branch
from
302bda3 to
1801cd0
Compare
tomaka
force-pushed
the
muxed-transport-change
branch
from
1801cd0 to
47a3a24
Compare
Merged
folsen
approved these changes
Jan 3, 2018
Contributor
folsen
left a comment
folsen
left a comment
There was a problem hiding this comment.
I have nothing to complain about, the API seems much cleaner and more intuitive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based over #80
Right now the
MuxedTransporttrait provides three methods:dial,listen_onanddial_and_listen. The difference betweendialanddial_and_listenis that the latter allows you to handle the substreams that are opened by the node you dialed.Whenever you use a muxed transport, you are strongly encouraged to use
dial_and_listeninstead of justdial.This PR simplifies this design by removing
dial_and_listenentirely, and replacing it with anext_incomingmethod that will consume the transport and return the next opened substream. Since the transport is generally clonable, you can easily turn that into a stream of incoming connections.