Implement the swarm #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folsen
approved these changes
Jan 3, 2018
| type Item = (); | ||
| type Error = IoError; | ||
|
|
||
| fn poll(&mut self) -> Poll<Self::Item, Self::Error> { |
Contributor
There was a problem hiding this comment.
This is a massively long function, is there any way to break it up in more comprehensible pieces? It's not like it's super hard to understand, it's just the same pattern over and over again, but I'd be inclined to organize it into smaller functions.
Member
Author
There was a problem hiding this comment.
I went with a long function like this, because in my opinion it would be more confusing to use separate functions or macros. But I can give it a shot if you think it would be better.
Contributor
There was a problem hiding this comment.
Yeah, it's hard to say. You may be right, because it is a simple pattern just repeating. I don't have a strong opinion on it. Keep it if you think this is the cleanest way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based over #81
Adds the
swarmfunction, which takes an upgradedTransportand a closure. The closure is called whenever a new node or a new substream of a node connected to us, and must turn the result of the upgrade into aFuture<Item = ()>.The function returns a
SwarmControllerand aFuture. The controller can be used to control the behaviour of the swarm, and theFuturemust be driven to completion.