-
Notifications
You must be signed in to change notification settings - Fork 172
[CIR][ThroughMLIR] Add TanOp Lowering #1540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @bcardosolopes , I am a new contributor to this project, and I've created a small PR to get the hang of things. Similar to the PRs here, here, I implemented a lowering for Tan (which I saw was missing). I'll add the lit test for it soon. Couple of questions:
Thanks! |
Hi, thanks for the PR
Yes, you need to use clang-format, code style in https://llvm.org/docs/CodingStandards.html
A lit test is enough for this PR, please add one! |
After you add the test please move this out of draft! |
✅ With the latest revision this PR passed the C/C++ code formatter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Adds implementation for TanOp's lowering via ThroughMLIR.
Adds implementation for TanOp's lowering via ThroughMLIR.