Skip to content

[CIR][ThroughMLIR] Add TanOp Lowering #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2025
Merged

[CIR][ThroughMLIR] Add TanOp Lowering #1540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8877959
Implementation for TanOp in CIR
goxul Apr 1, 2025
ca69fb5
Register pattern
goxul Apr 1, 2025
3355c61
rebase, clang-format
goxul Apr 2, 2025
9421187
Add lit test
goxul Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions clang/lib/CIR/Lowering/ThroughMLIR/LowerCIRToMLIR.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,18 @@ class CIRCosOpLowering : public mlir::OpConversionPattern<cir::CosOp> {
}
};

class CIRTanOpLowering : public mlir::OpConversionPattern<cir::TanOp> {
public:
using OpConversionPattern<cir::TanOp>::OpConversionPattern;

mlir::LogicalResult
matchAndRewrite(cir::TanOp op, OpAdaptor adaptor,
mlir::ConversionPatternRewriter &rewriter) const override {
rewriter.replaceOpWithNewOp<mlir::math::TanOp>(op, adaptor.getSrc());
return mlir::LogicalResult::success();
}
};

class CIRSqrtOpLowering : public mlir::OpConversionPattern<cir::SqrtOp> {
public:
using mlir::OpConversionPattern<cir::SqrtOp>::OpConversionPattern;
Expand Down Expand Up @@ -1418,8 +1430,8 @@ void populateCIRToMLIRConversionPatterns(mlir::RewritePatternSet &patterns,
CIRBitClrsbOpLowering, CIRBitFfsOpLowering, CIRBitParityOpLowering,
CIRIfOpLowering, CIRVectorCreateLowering, CIRVectorInsertLowering,
CIRVectorExtractLowering, CIRVectorCmpOpLowering, CIRACosOpLowering,
CIRASinOpLowering, CIRUnreachableOpLowering>(converter,
patterns.getContext());
CIRASinOpLowering, CIRUnreachableOpLowering, CIRTanOpLowering>(
converter, patterns.getContext());
}

static mlir::TypeConverter prepareTypeConverter() {
Expand Down
30 changes: 30 additions & 0 deletions clang/test/CIR/Lowering/ThroughMLIR/tan.cir
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
// RUN: cir-opt %s -cir-to-mlir -o %t.mlir
// RUN: FileCheck %s --input-file %t.mlir

module {
cir.func @foo() {
%1 = cir.const #cir.fp<1.0> : !cir.float
%2 = cir.const #cir.fp<2.0> : !cir.double
%3 = cir.const #cir.fp<3.0> : !cir.long_double<!cir.f80>
%4 = cir.const #cir.fp<4.0> : !cir.long_double<!cir.double>
%5 = cir.tan %1 : !cir.float
%6 = cir.tan %2 : !cir.double
%7 = cir.tan %3 : !cir.long_double<!cir.f80>
%8 = cir.tan %4 : !cir.long_double<!cir.double>
cir.return
}
}

// CHECK: module {
// CHECK-NEXT: func.func @foo() {
// CHECK-NEXT: %[[C0:.+]] = arith.constant 1.000000e+00 : f32
// CHECK-NEXT: %[[C1:.+]] = arith.constant 2.000000e+00 : f64
// CHECK-NEXT: %[[C2:.+]] = arith.constant 3.000000e+00 : f80
// CHECK-NEXT: %[[C3:.+]] = arith.constant 4.000000e+00 : f64
// CHECK-NEXT: %{{.+}} = math.tan %[[C0]] : f32
// CHECK-NEXT: %{{.+}} = math.tan %[[C1]] : f64
// CHECK-NEXT: %{{.+}} = math.tan %[[C2]] : f80
// CHECK-NEXT: %{{.+}} = math.tan %[[C3]] : f64
// CHECK-NEXT: return
// CHECK-NEXT: }
// CHECK-NEXT: }
Loading