Skip to content

[CIR][ThroughMLIR] Templatize unary math op lowerings. #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2025
Merged

[CIR][ThroughMLIR] Templatize unary math op lowerings. #1557

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb14931
Templatise math operations
goxul Apr 2, 2025
a664d58
1. Fix template name 2. run clang-format
goxul Apr 11, 2025
79ac64c
Add comment to describe changes
goxul Apr 11, 2025
7dedb7e
clang-format
goxul Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
1. Fix template name 2. run clang-format
  • Loading branch information
@goxul
goxul committed Apr 11, 2025
commit a664d58d2f9e1dc452c813fdb852bc6c364bef04
49 changes: 31 additions & 18 deletions clang/lib/CIR/Lowering/ThroughMLIR/LowerCIRToMLIR.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,10 @@ class CIRStoreOpLowering : public mlir::OpConversionPattern<cir::StoreOp> {
}
};

// Template for unary math op lowerings, to eliminate redundancy.

template <typename CIROp, typename MLIROp>
class CIRMathOpLowering : public mlir::OpConversionPattern<CIROp> {
class CIRUnaryMathOpLowering : public mlir::OpConversionPattern<CIROp> {
public:
using mlir::OpConversionPattern<CIROp>::OpConversionPattern;

Expand All @@ -289,23 +291,34 @@ class CIRMathOpLowering : public mlir::OpConversionPattern<CIROp> {
}
};

using CIRASinOpLowering = CIRMathOpLowering<cir::ASinOp, mlir::math::AsinOp>;
using CIRSinOpLowering = CIRMathOpLowering<cir::SinOp, mlir::math::SinOp>;
using CIRExp2OpLowering = CIRMathOpLowering<cir::Exp2Op, mlir::math::Exp2Op>;
using CIRExpOpLowering = CIRMathOpLowering<cir::ExpOp, mlir::math::ExpOp>;
using CIRRoundOpLowering = CIRMathOpLowering<cir::RoundOp, mlir::math::RoundOp>;
using CIRLog2OpLowering = CIRMathOpLowering<cir::Log2Op, mlir::math::Log2Op>;
using CIRLogOpLowering = CIRMathOpLowering<cir::LogOp, mlir::math::LogOp>;
using CIRLog10OpLowering = CIRMathOpLowering<cir::Log10Op, mlir::math::Log10Op>;
using CIRCeilOpLowering = CIRMathOpLowering<cir::CeilOp, mlir::math::CeilOp>;
using CIRFloorOpLowering = CIRMathOpLowering<cir::FloorOp, mlir::math::FloorOp>;
using CIRAbsOpLowering = CIRMathOpLowering<cir::AbsOp, mlir::math::AbsIOp>;
using CIRFAbsOpLowering = CIRMathOpLowering<cir::FAbsOp, mlir::math::AbsFOp>;
using CIRSqrtOpLowering = CIRMathOpLowering<cir::SqrtOp, mlir::math::SqrtOp>;
using CIRCosOpLowering = CIRMathOpLowering<cir::CosOp, mlir::math::CosOp>;
using CIRATanOpLowering = CIRMathOpLowering<cir::ATanOp, mlir::math::AtanOp>;
using CIRACosOpLowering = CIRMathOpLowering<cir::ACosOp, mlir::math::AcosOp>;
using CIRTanOpLowering = CIRMathOpLowering<cir::TanOp, mlir::math::TanOp>;
using CIRASinOpLowering =
CIRUnaryMathOpLowering<cir::ASinOp, mlir::math::AsinOp>;
using CIRSinOpLowering = CIRUnaryMathOpLowering<cir::SinOp, mlir::math::SinOp>;
using CIRExp2OpLowering =
CIRUnaryMathOpLowering<cir::Exp2Op, mlir::math::Exp2Op>;
using CIRExpOpLowering = CIRUnaryMathOpLowering<cir::ExpOp, mlir::math::ExpOp>;
using CIRRoundOpLowering =
CIRUnaryMathOpLowering<cir::RoundOp, mlir::math::RoundOp>;
using CIRLog2OpLowering =
CIRUnaryMathOpLowering<cir::Log2Op, mlir::math::Log2Op>;
using CIRLogOpLowering = CIRUnaryMathOpLowering<cir::LogOp, mlir::math::LogOp>;
using CIRLog10OpLowering =
CIRUnaryMathOpLowering<cir::Log10Op, mlir::math::Log10Op>;
using CIRCeilOpLowering =
CIRUnaryMathOpLowering<cir::CeilOp, mlir::math::CeilOp>;
using CIRFloorOpLowering =
CIRUnaryMathOpLowering<cir::FloorOp, mlir::math::FloorOp>;
using CIRAbsOpLowering = CIRUnaryMathOpLowering<cir::AbsOp, mlir::math::AbsIOp>;
using CIRFAbsOpLowering =
CIRUnaryMathOpLowering<cir::FAbsOp, mlir::math::AbsFOp>;
using CIRSqrtOpLowering =
CIRUnaryMathOpLowering<cir::SqrtOp, mlir::math::SqrtOp>;
using CIRCosOpLowering = CIRUnaryMathOpLowering<cir::CosOp, mlir::math::CosOp>;
using CIRATanOpLowering =
CIRUnaryMathOpLowering<cir::ATanOp, mlir::math::AtanOp>;
using CIRACosOpLowering =
CIRUnaryMathOpLowering<cir::ACosOp, mlir::math::AcosOp>;
using CIRTanOpLowering = CIRUnaryMathOpLowering<cir::TanOp, mlir::math::TanOp>;

class CIRShiftOpLowering : public mlir::OpConversionPattern<cir::ShiftOp> {
public:
Expand Down
Loading