Skip to content

Conversation

kares
Copy link
Contributor

@kares kares commented Feb 1, 2022

the feature itself comes from the mixin: logstash-plugins/logstash-mixin-http_client#39

@kares
Copy link
Contributor Author

kares commented Feb 1, 2022

in terms of testing the feature (provided by the mixin) - there's no existing TLS certificate testing in the plugin and
I do not feel like we need to invent the same test with every mixin usage, there's already functional asserts at logstash-plugins/logstash-output-http#126

@kares kares requested a review from kaisecheng February 1, 2022 07:18
@kares kares self-assigned this Feb 1, 2022
Copy link
Contributor

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍏

@kares kares merged commit cd98d27 into logstash-plugins:main Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants