Feat: add ssl_verification_mode => 'full' / 'none' #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due Manticore requiring Ruby >= 2.3
jsvd
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
minor nit picks to improve reading comprehension when tests fail, otherwise LGTM
next step is going to plugins that use this and adding documentation snippet for this new setting.
The direction we want to go is to group this mixin and the plugins that use it (http output, http poller) into an integration, to avoid this finicky weak link between plugins and mixins.
|
|
||
| case @ssl_verification_mode | ||
| when 'full' | ||
| # NOTE: would make sense to have :browser here but historically we've used the (:strict) default |
There was a problem hiding this comment.
We'll also want to have something like "certificate" for a mode that verifies the cert chain but doesn't perform hostname verification. Totally out of scope for this PR though.
Co-authored-by: João Duarte <[email protected]>
Co-authored-by: João Duarte <[email protected]>
Co-authored-by: João Duarte <[email protected]>
This was referenced Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ssl_verification_modeconfiguration option, with the default being'full'.Manticore wise, due backwards compatibility, the
'full'option translates toverify: :strict.This could be relaxed in the future (
verify: :browser) but would need more investigation/implementation whether we could force SAN to be present in the server certificate (same way as ES/Beats implement strict verification).closing #31 (alternate impl)
closing #34 (alternate impl)