Skip to content

Refactor: start using scheduler mixin #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 14, 2022
Merged

Refactor: start using scheduler mixin #134

merged 5 commits into from
Jun 14, 2022

Conversation

kares
Copy link
Contributor

@kares kares commented May 17, 2022 •
edited
Loading

@kares kares mentioned this pull request Jun 7, 2022
Closed
16 tasks
@kares kares marked this pull request as ready for review June 14, 2022 13:30
@kaisecheng kaisecheng self-requested a review June 14, 2022 14:15
kaisecheng
kaisecheng approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥭

andsel
andsel approved these changes Jun 14, 2022
View reviewed changes
Copy link

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kares kares merged commit 6caed0c into logstash-plugins:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andsel andsel andsel approved these changes

@kaisecheng kaisecheng kaisecheng approved these changes

Assignees

@kares kares

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kares @andsel @kaisecheng @roaksoax