Refactor: initialize time zone data eagerly #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kares
commented
Jun 14, 2022
| scheduler.cron('* * * * * *') { counter.increment_and_get; sleep 3.25 } # every second | ||
| scheduler.cron('* * * * * *') do # every second | ||
| counter.increment_and_get | ||
| sleep_at_least 3.25 |
There was a problem hiding this comment.
spec was failing occasionally (unrelated to the eager ::EtOrbi::EoTime.now above),
this + the lower frequency makes it more predictable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, with up-to-date rufus-scheduler,
EoTime.nowhappens onScheduler.new ...(fromstart).The problem is the mixin lazily initializes the scheduler on first use and thus the actual start of the scheduler might take a considerable time (esp. on CI) - this is problematic in terms of testing behavior that is using the scheduler (and has been a cause of several 🔴 false positives in plugins).
The code itself is extracted from http_poller and the change immediately stabilized the CI build, since we do not want to have scheduler impl specific code all over the plugin I am moving the eager initialization into the mixin.
This is not a concern for currently used rufus 3.0 (which simply uses
Time.now), thus theLoadErrorrescue. Once LS core updates the scheduler to>= 3.4we could remove the rescue.