Skip to content

fix otel setup#2269

Merged
lowsky merged 1 commit intomainfrom
fix-OTEL-setup
Apr 8, 2023
Merged

fix otel setup#2269
lowsky merged 1 commit intomainfrom
fix-OTEL-setup

Conversation

@lowsky
Copy link
Owner

@lowsky lowsky commented Apr 8, 2023

there was an issue with how sdk was created and "started" - it seems it was not adapted to latest API:

The start() method in the NodeSDK class has been recently updated to be synchronous (in open-telemetry/opentelemetry-js#3460) - it no longer returns a promise.

@vercel
Copy link

vercel bot commented Apr 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
coolboard ✅ Ready (Inspect) Visit Preview Apr 8, 2023 7:05pm

@cypress
Copy link

cypress bot commented Apr 8, 2023

Passing run #5665 ↗︎

0 6 0 0 Flakiness 0

Details:

fix otel setup
Project: coolboard-smoketest Commit: 110e885524
Status: Passed Duration: 00:39 💡
Started: Apr 8, 2023 7:16 PM Ended: Apr 8, 2023 7:17 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@lowsky lowsky merged commit a2fad71 into main Apr 8, 2023
@lowsky lowsky deleted the fix-OTEL-setup branch April 8, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant