Fix display issue for objects with length property #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mac-s-g |
|
@superfaz thanks for posting! reviewing now. |
|
nice fix! thanks for including a test. I'll comment when your changes are published to npm. |
|
published to npm: thanks again for the contribution @superfaz ! |
bespokebob
added a commit
to bespokebob/react-json-view
that referenced
this pull request
Mar 8, 2021
If an object has more keys than `groupArraysAfterLength`, then it will be rendered as an Array due to the changes in mac-s-g#336 Fix this logic so only arrays are rendered as arrays. Fixes mac-s-g#340
bespokebob
added a commit
to bespokebob/react-json-view
that referenced
this pull request
Mar 8, 2021
If an object has more keys than `groupArraysAfterLength`, then it will be rendered as an Array due to the changes in mac-s-g#336 Fix this logic so only arrays are rendered as arrays. Fixes mac-s-g#340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mac-s-g,
This pull request covers the issue #252 where the 'length' property is misinterpreted as the length of an array.
Best,