Skip to content

Fix display issue for objects with length property #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Fix display issue for objects with length property #336

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51890fa
Fix display issue for objects with length property
superfaz Feb 22, 2021
f4fe408
Update JsonViewer.js
superfaz Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix display issue for objects with length property
  • Loading branch information
@superfaz
superfaz committed Feb 22, 2021
commit 51890fa751cc574330e79e4ed95265fd69830a1c
3 changes: 2 additions & 1 deletion src/js/components/JsonViewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@ export default class extends React.PureComponent {
const namespace = [props.name];
let ObjectComponent = JsonObject;

const size = Array.isArray(props.src) ? props.src.length: Object.keys(props.src).length;
if (
props.groupArraysAfterLength &&
props.src.length > props.groupArraysAfterLength
size > props.groupArraysAfterLength
) {
ObjectComponent = ArrayGroup;
}
Expand Down
13 changes: 13 additions & 0 deletions test/tests/js/Index-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,4 +117,17 @@ describe("<Index />", function() {
)
expect(wrapper.find(".array-group")).to.have.length(3)
})

it("length is correct even if an object has a length property", function () {
const wrapper = render(
<Index
src={{
first: "first property",
second: "second property",
length: 1000
}}
/>
)
expect(wrapper.find(".object-size")).to.have.length(1)
})
})