Skip to content

Fix naming conventions and optional/required fields in company credit GraphQL schema #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
melnikovi merged 3 commits into from
Oct 22, 2020
Merged

Fix naming conventions and optional/required fields in company credit GraphQL schema #446

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0ed464
Add missing uids to the types and validate optional/required fields
melnikovi Oct 1, 2020
3620b9b
Add missing uids to the types and validate optional/required fields
melnikovi Oct 1, 2020
c9ce7e9
Clarify what is CompanyCreditOperation.uid
melnikovi Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clarify what is CompanyCreditOperation.uid
  • Loading branch information
@melnikovi
melnikovi committed Oct 21, 2020
commit c9ce7e974a0918ee7682eec3ef5c8f019535014a
2 changes: 1 addition & 1 deletion design-documents/graph-ql/coverage/b2b/company-credit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ type CompanyCreditHistory {
}

type CompanyCreditOperation {
uid: ID! @doc(description: "Unique identifier")
uid: ID! @doc(description: "Unique identifier") # id of the log entry
Copy link
Contributor

@cpartica cpartica Oct 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will have to add uid in all this schema as a lof the types don't have it still
for this MD is ok
but there's stuff left
https://github.com/magento/architecture/blob/cc87e2dcd22b09be02eaabd7affc553b4d7d13df/design-documents/graph-ql/coverage/b2b/company.md

date: String! @doc(description: "The date of the company credit operation")
type: CompanyCreditOperationType! @doc(description: "The type of the company credit operation")
amount: Money! @doc(description: "The amount fo the company credit operation")
Expand Down