Fix naming conventions and optional/required fields in company credit GraphQL schema #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabhuram93
reviewed
Oct 16, 2020
| } | ||
|
|
||
| type CompanyCreditOperation { | ||
| uid: ID! @doc(description: "Unique identifier") |
There was a problem hiding this comment.
@melnikovi can you add, what this identifier should be composed of.
cpartica
reviewed
Oct 22, 2020
| } | ||
|
|
||
| type CompanyCreditOperation { | ||
| uid: ID! @doc(description: "Unique identifier") # id of the log entry |
Contributor
There was a problem hiding this comment.
we will have to add uid in all this schema as a lof the types don't have it still
for this MD is ok
but there's stuff left
https://github.com/magento/architecture/blob/cc87e2dcd22b09be02eaabd7affc553b4d7d13df/design-documents/graph-ql/coverage/b2b/company.md
cpartica
approved these changes
Oct 22, 2020
melnikovi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Add missing uids to the types and validate optional/required fields.
Solution
Requested Reviewers
@cpartica, @prabhuram93