Skip to content

fix: Omit --detach option for run subcommand on Windows#4185

Merged
JohanMabille merged 1 commit into
mamba-org:mainfrom
jjerphan:fix/omit-detach-flags-on-windows
Mar 11, 2026
Merged

fix: Omit --detach option for run subcommand on Windows#4185
JohanMabille merged 1 commit into
mamba-org:mainfrom
jjerphan:fix/omit-detach-flags-on-windows

Conversation

@jjerphan
Copy link
Copy Markdown
Member

Description

The -d / --detach flags are not defined on Windows in run.cpp:

static bool detach = false;
#ifndef _WIN32
subcom->add_flag("-d,--detach", detach, "Detach process from terminal");
#endif

This makes some tests like TestRun.test_help_succeeds[--h--d] fail on Windows.

Type of Change

  • Bugfix
  • Feature / enhancement
  • CI / Documentation
  • Maintenance

Checklist

  • My code follows the general style and conventions of the codebase, ensuring consistency
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run pre-commit run --all locally in the source folder and confirmed that there are no linter errors.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@jjerphan jjerphan marked this pull request as ready for review March 11, 2026 09:22
@github-actions github-actions Bot added the release::bug_fixes For PRs fixing bugs label Mar 11, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.30%. Comparing base (35a3553) to head (dcb3f78).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4185      +/-   ##
==========================================
- Coverage   52.30%   52.30%   -0.01%     
==========================================
  Files         239      239              
  Lines       29088    29088              
  Branches     3082     3082              
==========================================
- Hits        15215    15214       -1     
- Misses      13870    13871       +1     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan force-pushed the fix/omit-detach-flags-on-windows branch from a104bbd to dcb3f78 Compare March 11, 2026 09:43
@JohanMabille JohanMabille merged commit 8ab699b into mamba-org:main Mar 11, 2026
37 checks passed
@jjerphan jjerphan deleted the fix/omit-detach-flags-on-windows branch March 11, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::bug_fixes For PRs fixing bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants