Skip to content

fix: Omit --detach option for run subcommand on Windows #4185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohanMabille merged 1 commit into from
Mar 11, 2026
Merged

fix: Omit --detach option for run subcommand on Windows #4185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion micromamba/tests/test_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@
from .helpers import create, random_string, subprocess_run, umamba_run

common_simple_flags = ["", "-d", "--detach", "--clean-env"]
# -d/--detach are not available on Windows (see run.cpp)
common_simple_flags_for_help = (
[f for f in common_simple_flags if f not in ("-d", "--detach")]
if platform == "win32"
else common_simple_flags
)
possible_characters_for_process_names = (
"-_" + string.ascii_uppercase + string.digits + string.ascii_lowercase
)
Expand Down Expand Up @@ -53,7 +59,7 @@ def test_unknown_exe_fails(self, option_flag, make_label_flags):
else:
assert fails is True

@pytest.mark.parametrize("option_flag", common_simple_flags)
@pytest.mark.parametrize("option_flag", common_simple_flags_for_help)
# @pytest.mark.parametrize("label_flags", naming_flags()) # TODO: reactivate after fixing help flag not disactivating the run
@pytest.mark.parametrize("help_flag", ["-h", "--help"])
@pytest.mark.parametrize("command", ["", simple_short_program()])
Expand Down
Loading