bump nextcloud version to 20 #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasdelellis
requested changes
Oct 13, 2020
Owner
matiasdelellis
left a comment
matiasdelellis
left a comment
There was a problem hiding this comment.
Hi @dassio
Thank you very much for split the patch.. Returns the test of NC 19 and we merge it. 😄
Owner
|
p.s: I was worried about the new Bootstraping process but it seems optional. https://docs.nextcloud.com/server/latest/developer_manual/app_development/bootstrap.html#bootstrapping |
Contributor
Author
yes, i am trying to find a way so that we can active the unified search but also be compatible with NC19 |
Signed-off-by: xiangbin.li <[email protected]>
Owner
Yes,, Please.. 😄 See: |
Owner
|
Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI BUILD: https://travis-ci.com/github/dassio/facerecognition/builds/189297176
Edit:
i also did an manual test, it seems to be ok