Unified search implementation #2200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
enh/search
branch
from
15221e1 to
89189a9
Compare
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Pushed a fix for that. |
Contributor
Now the search is working for the card title, card description, board name |
Member
Author
Let's do this in a follow-up as it it less urgent imo. Implementation can be based on https://github.com/juliushaertl/server/blob/2c699e090179a2ca235d28540b5999e27c36b9de/apps/comments/lib/Search/LegacyProvider.php#L66 and https://github.com/nextcloud/server/blob/ea8f68bea6957ae459ff1ba6849b25354b3f0093/apps/comments/lib/Search/CommentsSearchProvider.php |
juliusknorr
force-pushed
the
enh/search
branch
from
86b3475 to
7039125
Compare
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
enh/search
branch
from
7039125 to
081a518
Compare
Member
Author
|
Missing pieces for a follow up:
|
jakobroehrl
approved these changes
Sep 1, 2020
Contributor
jakobroehrl
left a comment
jakobroehrl
left a comment
There was a problem hiding this comment.
This thing is working!
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.