Skip to content

cleanup_spec < Fixes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 12 commits into
base: cleanup_spec
Choose a base branch
from
Draft

cleanup_spec < Fixes #1

wants to merge 12 commits into from

Conversation

@matthewhively
Copy link
Owner

@matthewhively matthewhively commented Jul 21, 2025

  • Modified update command's thor CLI description
  • renamed update_gems => update_outdated_gems. It was too similar to update_gem method
  • Raise human friendly exception within updated_version_for
  • Fixed commit message to actually differ when only dependencies are updated
  • Skip commit if no changes are staged
  • Fixed issue that would incorrectly postpone merging dependency only changes into a later commit
  • renamed updated_version_for => bundled_version_for. Better matches its functionality
  • Updated some variables within updater_spec.rb
  • Make each context in updater_spec consistent with a before(:each) block
  • Add an example for when only dependencies are updated. Coverage is now 100%

@matthewhively
Tweak thor CLI description for update command
2139d55
@matthewhively
Update change method name to "update_outdated_gems"
ccf8f39 
Make it less visually similar to "update_gem". Avoid developer confusion
@matthewhively
Give a human friendly exception message when we encounter an issue here
bd06750 
An example of when this exception can be triggered is when installing nokogiri under the generic ruby platform. It has a dependency of "mini_portile2", but when installing the gem, it will actually install a platform specific version of nokogiri if one exists (for instance arm64-darwin) which do not have "mini_portile2" as a dependency. Therefore the Gemfile.lock will list "mini_portile2" in specs:, but it won't actually be installed on your system. Therefore "bundle list --paths" for that gem will not exist.
@matthewhively
Fix commit message to actually differ when only dependencies are updated
2d94901 
Both versions of the commit message have "gemname" as the second word
@matthewhively
Skip commit if no changes are staged
b71641a
@matthewhively
Fixed issue when only dependencies are updated
b04cfd7 
When only the gem's dependencies were updated, those were not committed, instead they were added into the next successfully updated gem's commit.
This was confusing.
@matthewhively
Changed variable name to match function
9e701ea
@matthewhively
Adjusted some variable names
8314ba4
@matthewhively
Remove un-necessary mocking of the actual update_cmd
93411d7 
System is always called with that command.
@matthewhively
Make each context in updater_spec consistent with a before(:each) block
f3fcebc
@matthewhively
Add an example for when only dependencies are updated
04ec844 
Coverage is now 100%
@matthewhively
Update bummr version
951080c
@matthewhively matthewhively mentioned this pull request Jul 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matthewhively