Cleanup spec tests and gem build #76
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't need anything related to testing circleci spec Rakefile Don't need meta build information .ruby-version gemspec file Gemfile Gemfile.lock Don't need gitignore either
using an invalid sha "testsha" results in: fatal: ambiguous argument 'testsha': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git <command> [<revision>...] -- [<file>...]'
Now it is the caller's responsibility to print or not the resulting message This cleans up some pointless output during spec testing
Also puts statements should use regular ' instead of backticks `
Resolves "fatal: pathspec 'vendor/cache' did not match any files"
- Write the report into `/coverage/<branch_name>` - Exclude all spec files from coverage
Include explanations why they are excluded
|
I have 4 more branches for more specific feature adds/tweaks that are built ontop of this branch. Version number was updated so that it couldn't be forgotten. I'm not sure how you want to increment it. |
|
You can see pending PRs for the other 4 branches here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included changes:
gitignoreto exclude more files/foldersfatal: ambiguous argument 'testsha': unknown revision or path not in the working tree.fatal: pathspec 'vendor/cache' did not match any filesby ensuringvendor/cacheexistsBummr::Remover.instance.remove_committesting%x{}instead'insteadcli#display_info- this is just informational for the users. Its always printed.cli#check- redundant with spec/check_spec.rbcli#remove_commit- redundant with spec/lib/remover_spec.rboutdated#gemfile- no need to test whether linux "cat Gemfile" works/coverage/<branch_name>