Skip to content

Conversation

@hamishwillee
Copy link
Contributor

FF141 supports the source option to HTMLElement.showPopover() and HTMLElement.togglePopover(), and the force option to HTMLElement.togglePopover() in https://bugzilla.mozilla.org/show_bug.cgi?id=1936411

This adds the features.

Related docs work can be tracked in mdn/content#40027

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:m [PR only] 25-100 LoC changed labels Jun 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2025

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

],
"support": {
"chrome": {
"version_added": false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, I can't find evidence that they are supported in chrome or Safari, but nor can I find evidence they aren't

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"deprecated": false
}
},
"force": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied the pattern of source.
For both this and source shouldn't the actual pattern be as below, based on the schema? Or did that change?

Suggested change
"force": {
"option_force": {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that force can be both a parameter and an option, and the option came later, we might want to record it as both force_parameter and force_option, to avoid confusion.

Copy link
Contributor Author

@hamishwillee hamishwillee Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That is absolutely the right thing to do. I have changed this to match the expected schema and key names.

PS Thanks for doing the research on when these were introduced in chrome/safari

"deprecated": false
}
},
"force": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that force can be both a parameter and an option, and the option came later, we might want to record it as both force_parameter and force_option, to avoid confusion.

],
"support": {
"chrome": {
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the size:l [PR only] 101-1000 LoC changed label Jun 30, 2025
@hamishwillee hamishwillee requested a review from caugner June 30, 2025 00:09
@caugner caugner changed the title FF141 HTMLElement.show/togglePopover() source and force option FF141 adds HTML popover source + force option Jul 1, 2025
@caugner caugner merged commit 56f3997 into mdn:main Jul 1, 2025
6 checks passed
@mdn-bot mdn-bot mentioned this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:l [PR only] 101-1000 LoC changed size:m [PR only] 25-100 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants